spawn new os_window on active screen on macOS #6932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixKratz
changed the title
|
Rather than disabling cascading which would break expected behavior on this platform why not check if the cascade point is on the same monitor and only use it then? |
|
The newest commit checks if the cascade point is on the same screen, if not, it is reset to the CGPointZero, such that cascading of further windows will work on that monitor (see https://developer.apple.com/documentation/appkit/nswindow/1419392-cascadetopleftfrompoint?language=objc). |
fix wording reset cascade point to zero point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug discussed in #6930.