Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote/escape application-provided build options for the shell used to invoke clspv #599

Open
kpet opened this issue Aug 13, 2023 · 1 comment

Comments

@kpet
Copy link
Owner

kpet commented Aug 13, 2023

In builds where clspv is a separate binary, we're currently using the shell to execute it. Some applications (e.g. hashcat) use build options that the shell interprets. Those need to be quoted/escaped or we need to stop using the shell when invoking clspv. See #598.

@giridhart
Copy link

@zwang20 The fix merged it expects option to have space after -D
For example, -DM2S(x)=XM2S(x) is not handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants