Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote application-provided build options for the shell used to invoke clspv #601

Merged
merged 3 commits into from
Aug 19, 2023
Merged

Quote application-provided build options for the shell used to invoke clspv #601

merged 3 commits into from
Aug 19, 2023

Conversation

zwang20
Copy link
Contributor

@zwang20 zwang20 commented Aug 13, 2023

See #599

kpet
kpet approved these changes Aug 19, 2023
View reviewed changes
Copy link
Owner

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it! I'd started working on it with a slightly different approach that would extend better to supporting quoting of arguments but this works for hashcat and does not seem to regress anything else, merging as a first step. Thanks!

@kpet kpet merged commit b08793c into kpet:main Aug 19, 2023
@zwang20 zwang20 deleted the dev branch August 20, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpet kpet kpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwang20 @kpet