Tidy up mappings when buffer map commands fail to execute #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer mappings are created at command creation time. When the command fails execution, either directly or because its dependencies failed, the mapping needs to be destroyed. Caught by the Vulkan validation layers. Change-Id: I53eef3c4bc4c7f4c5f94ade39b16bde558e9da2c Signed-off-by: Kévin Petit <[email protected]>
|
Image mapping seems to suffer from similar issues. deferring to #553. |
rjodinchr
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer mappings are created at command creation time. When the command fails execution, either directly or because its dependencies failed, the mapping needs to be destroyed.
Caught by the Vulkan validation layers.
Change-Id: I53eef3c4bc4c7f4c5f94ade39b16bde558e9da2c