Single command with feature flags #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored cli, using Click now. * Depricated cli arg --dataflow * Adds new features: - pyrandall simulate scenarios/file1 scenarios/file2. Also accepting linux pipes eg. `cat file1 | pyrandall simulate` - event and result files will be looked up not based on dataflow dir. But by convention relatively to the scenarios dir.
VERSION file is now added to package resources
motivation: requests user-agent keeps braking vcrpy fixtures Added tests/unit/test_requests_http_useragent.py this introduced side-effects in vcr config. Thus refactored vcr import to a vcr fixture. I evaluated github.com/kiwicom/pytest-recording but the tests need cassette in as test argument
stefanooldeman
force-pushed
the
feature/cli-click
branch
from
92ae588 to
a2638cb
Compare
stefanooldeman
force-pushed
the
feature/cli-click
branch
from
327d5bf to
0a6f83a
Compare
stefanooldeman
changed the title
this file was overwritten accidentally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #3
This will prepare pyrandall API for async e2e runs. Meaning the default behavior becomes simulate and validate as consecutive steps (blocking) or asynchronous steps where pyrandall starts consuming first (validate if you will) and producing after (simulate).
This will allow pyrandall to accurately measure the latency of a streaming consumer since the overhead of starting a kafka consume is moved out of the validation.
Therefore the API is moving away from the "subcommand" pattern. Instead users can use flags
--only-simulateand--only-validatewhen needed.TODO: