forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Misc][LoRA] Add PEFTHelper for LoRA (vllm-project#11003)
Signed-off-by: Jee Jee Li <[email protected]>
- Loading branch information
Showing
4 changed files
with
160 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
# Adapted from: https://github.com/huggingface/peft/blob/main/src/peft/tuners/lora/config.py | ||
|
||
import math | ||
from dataclasses import MISSING, dataclass, field, fields | ||
from typing import Literal, Optional, Union | ||
|
||
|
||
@dataclass | ||
class PEFTHelper: | ||
# Required fields | ||
r: int | ||
lora_alpha: int | ||
target_modules: Union[list[str], str] | ||
|
||
bias: Literal["none", "all", "lora_only"] = field(default="none") | ||
modules_to_save: Optional[list[str]] = field(default=None) | ||
use_rslora: bool = field(default=False) | ||
use_dora: bool = field(default=False) | ||
# long lora field | ||
context_length: int = field(default=0) | ||
# Extra vllm field, start with 'vllm_' to avoid conflict | ||
vllm_max_position_embeddings: Optional[int] = field(default=False) | ||
vllm_scaling_factor: Optional[float] = field(default=None) | ||
|
||
def _validate_features(self): | ||
error_msg = [] | ||
|
||
if self.modules_to_save: | ||
error_msg.append("vLLM only supports modules_to_save being None.") | ||
if self.use_rslora: | ||
error_msg.append("vLLM does not yet support RSLoRA.") | ||
|
||
if self.use_dora: | ||
error_msg.append("vLLM does not yet support DoRA.") | ||
|
||
if error_msg: | ||
raise ValueError(f"{', '.join(error_msg)}") | ||
|
||
def __post_init__(self): | ||
self._validate_features() | ||
if self.context_length: | ||
if self.vllm_max_position_embeddings is None: | ||
self.vllm_max_position_embeddings = self.context_length | ||
self.vllm_scaling_factor = float( | ||
math.ceil(self.context_length / | ||
self.vllm_max_position_embeddings)) | ||
|
||
@classmethod | ||
def from_dict(cls, config_dict: dict) -> "PEFTHelper": | ||
# Get all field information from the class | ||
class_fields = {f.name: f for f in fields(cls)} | ||
# Check for required fields | ||
required_fields = { | ||
name | ||
for name, f in class_fields.items() | ||
if f.default is MISSING and f.default_factory is MISSING | ||
} | ||
|
||
# Identify any missing required fields | ||
missing_fields = required_fields - set(config_dict.keys()) | ||
if missing_fields: | ||
raise ValueError( | ||
f"Missing required configuration fields: {missing_fields}") | ||
|
||
# Filter out fields that aren't defined in the class | ||
filtered_dict = { | ||
k: v | ||
for k, v in config_dict.items() if k in class_fields | ||
} | ||
return cls(**filtered_dict) |