Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtwebengine: Use clang for native toolchain as well #1008

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

kraj
Copy link
Owner

@kraj kraj commented Sep 19, 2024

This makes the chromium build less confused when mixing native compiler for gcc and target compiler for clang this does not sit well with gn build system and it starts to pass clang options to gcc, which does not always work


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

This makes the chromium build less confused when mixing
native compiler for gcc and target compiler for clang
this does not sit well with gn build system and it starts
to pass clang options to gcc, which does not always work

Signed-off-by: Khem Raj <[email protected]>
@kraj kraj merged commit f3cf775 into kraj:master Sep 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant