Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix racing on building lib32-llvm-project-source-19.1.0 and llvm-project-source-19.1.0 #1017

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

hongxu-jia
Copy link
Contributor

@hongxu-jia hongxu-jia commented Oct 12, 2024

While enabling multilib, build lib32-llvm-project-source-19.1.0 and llvm-project-source-19.1.0 at the same time:

$ MACHINE = "qemux86-64"
$ require conf/multilib.conf
$ MULTILIBS = "multilib:lib32"
$ DEFAULTTUNE:virtclass-multilib-lib32 = "x86"
$ bitbake lib32-llvm-project-source-19.1.0 llvm-project-source-19.1.0
...
$ cat tmp/work-shared/llvm-project-source-19.1.0-r0/temp/log.task_order
20241012-070604.819630 do_recipe_qa (2728706): log.do_recipe_qa.2728706
20241012-070604.883194 do_recipe_qa (2728707): log.do_recipe_qa.2728707
20241012-070605.037448 do_fetch (2728779): log.do_fetch.2728779
20241012-070605.165280 do_fetch (2728848): log.do_fetch.2728848
20241012-071030.798104 do_unpack (2733554): log.do_unpack.2733554
20241012-071030.864536 do_unpack (2733559): log.do_unpack.2733559

There are two tasks for do_fetch, do_unpack and others, so there are race issues.

Both of them have the same hardcode 'llvm-project-source-' prefix in ${WORKDIR} and ${S}, explicitly disable lib32-llvm-project-source-19.1.0 for multilib

Set llvm-project-source as BPN of llvm-project-source-19.1.0


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

…urce-19.1.0 and llvm-project-source-19.1.0

While enabling multilib, build lib32-llvm-project-source-19.1.0 and
llvm-project-source-19.1.0 at the same time:

    $ MACHINE = "qemux86-64"
    $ require conf/multilib.conf
    $ MULTILIBS = "multilib:lib32"
    $ DEFAULTTUNE:virtclass-multilib-lib32 = "x86"
    $ bitbake lib32-llvm-project-source-19.1.0 llvm-project-source-19.1.0
    ...
    $ cat tmp/work-shared/llvm-project-source-19.1.0-r0/temp/log.task_order
    20241012-070604.819630 do_recipe_qa (2728706): log.do_recipe_qa.2728706
    20241012-070604.883194 do_recipe_qa (2728707): log.do_recipe_qa.2728707
    20241012-070605.037448 do_fetch (2728779): log.do_fetch.2728779
    20241012-070605.165280 do_fetch (2728848): log.do_fetch.2728848
    20241012-071030.798104 do_unpack (2733554): log.do_unpack.2733554
    20241012-071030.864536 do_unpack (2733559): log.do_unpack.2733559

There are two tasks for do_fetch, do_unpack and others, so there are race issues.

Both of them have the same hardcode 'llvm-project-source-' prefix in ${WORKDIR} and
${S}, explicitly disable lib32-llvm-project-source-19.1.0 for multilib

Set llvm-project-source as BPN of llvm-project-source-19.1.0

Signed-off-by: Hongxu Jia <[email protected]>
@hongxu-jia hongxu-jia requested a review from kraj as a code owner October 12, 2024 07:22
Copy link
Owner

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kraj kraj merged commit 7cf1f0e into kraj:master Oct 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants