Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcc: fix some of python script with wrong shebang #820

Closed
wants to merge 3 commits into from

Conversation

chenxy1988
Copy link
Contributor

The examples/tracing/nflatency.py has already upgraded the shebang to python3 on upstream, so when we apply the do_install:append function, the shebang of nflatency.py become "/usr/bin/env python33"


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

the upstream changed the shebang of python scripts in tools folder[1],
this would cause do_install:append cannot conver all scripts.

[1] iovisor/bcc@3f5e402

Signed-off-by: Xiangyu Chen <[email protected]>
examples/tracing/nflatency.py has already upgraded the shebang to python3 on upstream,
so when we apply the do_install:append function, the shebang of nflatency.py become
/usr/bin/env python33

Signed-off-by: Xiangyu Chen <[email protected]>
@chenxy1988 chenxy1988 requested a review from kraj as a code owner July 12, 2023 06:06
@chenxy1988 chenxy1988 closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant