Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling version bumps for path dependencies when using UvPyprojectHandler #303

Merged
merged 19 commits into from
Jan 28, 2025
Merged

Enabling version bumps for path dependencies when using UvPyprojectHandler #303

merged 19 commits into from
Jan 28, 2025

Conversation

Ghelfi
Copy link
Contributor

@Ghelfi Ghelfi commented Jan 24, 2025

No description provided.

@antoinebrl antoinebrl requested review from NiklasRosenstein and removed request for NiklasRosenstein January 24, 2025 20:29
@Ghelfi Ghelfi force-pushed the aghelfi/uv-path-dependencies-version branch 2 times, most recently from f0f5e1e to 124b957 Compare January 27, 2025 08:53
@Ghelfi Ghelfi requested a review from antoinebrl January 27, 2025 12:07
antoinebrl
antoinebrl reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@antoinebrl antoinebrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Just couple of comments to simplify and specialize the test. This will reduce potential sources of errors and make the tests run faster.

examples/uv-project-relative-import/.kraken.py Outdated Show resolved Hide resolved
examples/uv-project-relative-import/.kraken.py Outdated Show resolved Hide resolved
kraken-build/tests/kraken_std/integration/python/test_python.py Outdated Show resolved Hide resolved
@Ghelfi Ghelfi force-pushed the aghelfi/uv-path-dependencies-version branch from 4bf327e to 972d00c Compare January 27, 2025 13:59
@Ghelfi Ghelfi force-pushed the aghelfi/uv-path-dependencies-version branch from 92be47c to 2cca5ce Compare January 28, 2025 08:49
@Ghelfi Ghelfi merged commit ae4fad4 into kraken-build:develop Jan 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinebrl antoinebrl antoinebrl approved these changes

@srstevenson srstevenson srstevenson approved these changes

Assignees

@Ghelfi Ghelfi

Labels
None yet
Projects
Kraken
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ghelfi @srstevenson @antoinebrl