V2.x #72
Merged
V2.x #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunwarman
reviewed
Jan 4, 2017
| @@ -0,0 +1,101 @@ | |||
| //const Fs = require('fs'); | |||
shaunwarman
reviewed
Jan 4, 2017
|
|
||
| return Promise.all([ apiResolver, fileResolver, validatorResolver ]).then(resolved => { | ||
| let routes = []; | ||
| let [ api, files, validators ] = resolved; |
There was a problem hiding this comment.
Guessing order is maintained from Promise.all ?
shaunwarman
reviewed
Jan 4, 2017
| } else { | ||
| //If handlers options is not set, use the default dir name `handlers` (only if the dir exists). | ||
| let defaultPath = Path.join(basedir, './handlers'); | ||
| ////For a one time lookup and invocation during configuration, |
|
Can this be merged? Because the target is a new branch altogether - |
|
merging this PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is-my-json-validvalidator by default, instead ofenjoi. (Option to usejoischema - useful for hapi integration).swagvalimodule to build validators.