prevent to overwrite handlers when handler is created already #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A result of
fs.readdirSync(dir)
is important because it could create error when the order of directory name precede filename.for example, let's assume that there is two files.
handlers/users.js
handlers/users/{userId}.js
Normally the result of
fs.readdirSync(dir)
will be ['users.js', 'users']. it works fine.However, when the result of
fs.readdirSync(dir)
is [ 'users', 'users.js']. it makes error. it will overwrite users.js's handler.I faced this situation when I tried to use pkg(https://github.com/zeit/pkg) for my project using swaggerize-hapi
I read the api document for fs.readdirSync, I cannot found the order of the result fixed.
I think the code requesting pull request prevent that kind of possible error situation.
Thanks!