Feature/apcu_set_ttl Add function to set the TTL of an existing entry atomically #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Jun 1, 2024
| @@ -539,6 +539,34 @@ PHP_APCU_API zend_bool apc_cache_store( | |||
| return ret; | |||
| } /* }}} */ | |||
|
|
|||
| /* {{{ apc_cache_set_ttl */ | |||
| PHP_APCU_API zend_bool apc_cache_update_ttl( | |||
| apc_cache_t* cache, zend_string *key, const int32_t ttl) { | |||
There was a problem hiding this comment.
Suggested change
| apc_cache_t* cache, zend_string *key, const int32_t ttl) { | |
| apc_cache_t *cache, zend_string *key, int32_t ttl) { |
| Z_PARAM_LONG(ttl) | ||
| ZEND_PARSE_PARAMETERS_END(); | ||
|
|
||
| t = apc_time(); |
| PHP_FUNCTION(apcu_set_ttl) { | ||
| zend_string *key; | ||
| zend_long ttl = 0L; | ||
| zval *success = NULL; |
| ZEND_PARSE_PARAMETERS_START(1, 2) | ||
| Z_PARAM_STR(key) | ||
| Z_PARAM_OPTIONAL | ||
| Z_PARAM_LONG(ttl) |
| return 0; | ||
| } | ||
|
|
||
| entry->ctime = t; |
There was a problem hiding this comment.
Hm, should this really be setting ctime and not mtime (or neither)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APCu lacks a nice way to update the TTL of an entry. Currently, you'd have to implement your own critical section, fetch the value of an entry, and then store it back. I think there are many use cases with websites where one would want to create a cache entry with a short life and then extend its lifespan on a subsequent request from the browser.
I think this will be especially useful in combination with apcu_inc, apcu_dec, and apcu_cas. Because calling apcu_store (the only way to extend TTL ATM) after them defeats their purpose.
This PR adds
apcu_set_ttl($key, int $ttl = 0): bool. If entry with the $key has been successfully updated, function returns true, else, false.