Delete locks whenever jobs are removed via web UI. #27
Conversation
|
|
||
| def delete_ext | ||
| cklass = klass.constantize | ||
| cklass.unlock!(args.first) if cklass.respond_to? :lock |
There was a problem hiding this comment.
It looks like this supports only workers with manual option. Can we make it work with regular ones as well?
There was a problem hiding this comment.
Also, unlock! is not something that UniqueJobs provides. This is just an example.
|
Good points. I'll work on those later this week (I'm a bit caught up on other things atm). :) |
|
No problem. Thanks for your help! Let me know if you need something. |
|
@dychen good catch, exactly what we need:) |
|
Hey @dychen, any progress on this? I'd like to merge & release this, but lack of tests is stopping me. |
|
Really sorry, bro. I've been caught up with new job stuff. I'll get on it ASAP. |
|
@dychen it does not work for me when I delete jobs from Sidekiq web monitoring. Temporarily, I'm cleaning up Redis to make it work. |
|
Hey guys, any change of merge this? []'s |
|
any news about this PR? does it work properly? |
@krasnoukhov
For this: #10