Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linking issue #4

Merged
merged 1 commit into from
Jun 15, 2021
Merged

fix: linking issue #4

merged 1 commit into from
Jun 15, 2021

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Jun 15, 2021

Fix issue with linking. This is a bit hacky and messy, but should be easy to clean up. The ".400" bothers me. See #1.

@henryiii
Copy link
Contributor Author

I don't think you need the find_package(Arrow REQUIRED) at all, it likely finds the system Arrow, rather than the one inside the Python package.

@kratsg
Copy link
Owner

kratsg commented Jun 15, 2021

I don't think you need the find_package(Arrow REQUIRED) at all, it likely finds the system Arrow, rather than the one inside the Python package.

Probably not. However, Arrow's docs were not very clear here and seems to imply that you needed a system Arrow, and then pull in pyarrow from the other place. Then I started panicking thinking that somehow I was linking against the wrong arrow in some way...

@henryiii
Copy link
Contributor Author

It has a libarrow and a libarrow_python in the package. If the version doesn't match, I don't think you'd want to mix the system Arrow and the package Arrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants