fix: fixing CV path + memoizing functions in Navigation.tsx

krckyboy · Nov 18, 2024 · bc3582d · bc3582d
1 parent f12e65f
commit bc3582d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/frontend/public/cv/CV - dark.pdf → frontend/public/cv/CV-dark.pdf b/frontend/public/cv/CV - dark.pdf → frontend/public/cv/CV-dark.pdf
diff --git a/frontend/src/app/blog/_navigation/Navigation.tsx b/frontend/src/app/blog/_navigation/Navigation.tsx
@@ -1,4 +1,4 @@
-import React, { FunctionComponent, useMemo } from 'react';
+import React, { FunctionComponent, useCallback, useMemo } from 'react';
 import styles from './styles.module.scss';
 import Link from 'next/link';
 import qs from 'qs';
@@ -14,13 +14,13 @@ const Navigation: FunctionComponent<Props> = ({ currentPageCount, pageNumber, ca
   const rangeEnd = currentPageCount;
   const maxPagesToShow = 3;
 
-  const generateQueryString = (page: number) => {
+  const generateQueryString = useCallback((page: number) => {
     const queryParams = {
       category,
       page
     };
     return qs.stringify(queryParams);
-  };
+  }, [category]);
 
   const generatePageLinks = () => {
     const links = [];
@@ -66,7 +66,7 @@ const Navigation: FunctionComponent<Props> = ({ currentPageCount, pageNumber, ca
     return links;
   };
 
-  const memoizedGeneratePageLinks = useMemo(() => generatePageLinks(), [rangeStart, pageNumber, rangeEnd, maxPagesToShow]);
+  const memoizedGeneratePageLinks = useMemo(generatePageLinks, [pageNumber, rangeEnd, generateQueryString]);
 
   return (
     <div className={styles.container}>