WIP, untested: integrate more into SnoizeMIDI.

- Don't use a separate show control message type, just put it all in sysex message
- Cache dataForDisplay in sysex messages
- rename some stuff
- fix leak in parseCueItemsData

TODO:
- In tests target, use config files instead of ad-hoc settings
- test failing in parseCueItemsData, clean that up probably
- check this with MIDI Show Control spec, I suspect there is a lot more to show
- new TODOs in sysex message, e.g. checking for message lengths

Applications/MIDIMonitor/SMMMonitorWindowController.m

@@ -633,6 +633,8 @@ - (void)trivialWindowSettingsDidChange
 
 - (void)displayPreferencesDidChange:(NSNotification *)notification
 {
+    [self.displayedMessages makeObjectsPerformSelector:@selector(invalidateDisplayCache)];
+
     [self.messagesTableView reloadData];
 }
 

Frameworks/SnoizeMIDI/SMMessage.h

@@ -151,4 +151,6 @@ extern NSString *SMProgramChangeBaseIndexPreferenceKey;
 - (NSString *)expertDataForDisplay;
 - (NSString *)originatingEndpointForDisplay;
 
+- (void)invalidateDisplayCache;
+
 @end

Frameworks/SnoizeMIDI/SMMessage.m

@@ -530,6 +530,11 @@ - (NSString *)originatingEndpointForDisplay
     }
 }
 
+- (void)invalidateDisplayCache
+{
+    // Do nothing by default. Subclasses that cache results that depend on display preferences should override to invalidate their cache.
+}
+
 @end
 
 

Frameworks/SnoizeMIDI/SMMessageParser.m

@@ -18,7 +18,6 @@
 #import "SMSystemCommonMessage.h"
 #import "SMSystemRealTimeMessage.h"
 #import "SMSystemExclusiveMessage.h"
-#import "SMShowControlMessage.h"
 #import "SMInvalidMessage.h"
 
 
@@ -342,11 +341,7 @@ - (SMSystemExclusiveMessage *)finishSysExMessageWithValidEnd:(BOOL)isEndValid;
     // The MIDI spec says that messages should end with this byte, but apparently that is not always the case in practice.
 
     if (readingSysExData) {
-        if (((uint8_t *)readingSysExData.mutableBytes)[2] == 0x02) { // MIDI Show Control Message
-            message = [SMShowControlMessage showControlMessageWithTimeStamp:startSysExTimeStamp data:readingSysExData];
-        } else {
-            message = [SMSystemExclusiveMessage systemExclusiveMessageWithTimeStamp:startSysExTimeStamp data:readingSysExData];
-        }
+        message = [SMSystemExclusiveMessage systemExclusiveMessageWithTimeStamp:startSysExTimeStamp data:readingSysExData];
 
         [readingSysExData release];
         readingSysExData = nil;