Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable noPropertyAccessFromIndexSignature and noUncheckedIndexedAccess #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sporto
Copy link

@sporto sporto commented Nov 14, 2024

Types of changes

We want to have these two typescript checks on:

  • noPropertyAccessFromIndexSignature
  • noUncheckedIndexedAccess

But our project won't typecheck because of errors in universal routes.
Apparently it is not possible to ignore these errors using exclude or ignoreLibChecks.
See microsoft/TypeScript#44205 (comment)

  • [x ] Bug fix (non-breaking change which fixes an issue)

This fixes the errors here.

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@sporto sporto marked this pull request as ready for review November 14, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant