fix: properly scale emote-only messages with custom emotes #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TheOneWithTheBraid
commented
Nov 30, 2023
TheOneWithTheBraid
commented
TheOneWithTheBraid
force-pushed
the
braid/custom-emote-size
branch
from
50e77a6
to
86cfa3d
Compare
TheOneWithTheBraid
force-pushed
the
braid/custom-emote-size
branch
from
86cfa3d
to
b4de0d4
Compare
Signed-off-by: The one with the braid <[email protected]>
TheOneWithTheBraid
force-pushed
the
braid/custom-emote-size
branch
from
b4de0d4
to
ec6efe2
Compare
|
Rebased onto current changes to HTML renderer code, I'd appreciate some review, @krille-chan ! |
| @@ -525,3 +553,15 @@ class MatrixPill extends StatelessWidget { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| FontSize? tryGetParentFontSize(ExtensionContext context) { | |||
There was a problem hiding this comment.
This function is basically the relevant part scaling custom emotes into the right parenting text size. I'm sure it could be better or "more complete" but from everything I see as of now how we use font sizes in the HTML renderer, it should work in any occurring case.
|
This pull request is stale because it has been open for 120 days with no activity. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.