Switch nginx to one that doesn't need root #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed: deployed @ https://fluffychat.g4v.dev/ |
BhasherBEL
approved these changes
Mar 9, 2024
|
I don't know if all consumers of the docker image prefer this 🤔 so no idea what to do with it. Can you maybe host this by yourself? |
krille-chan
added
the
stale
|
Yea I can't say either. I generally think rootless docker images are good practice. I believe I have a docker image created whenever a new release happens, so I'm not desperate, but being lazy it's nicer upstream :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer running unprivledged containers whenever possible. It seems like an easy win to run as non root.
That being said, if it works, it would be a breaking change since its port 8080 not 80 now