refactor: generalize symbol variable naming

kripod · Apr 17, 2024 · 09ea878 · 09ea878
1 parent 09198d8
commit 09ea878
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/src/content/quoteRecords/_scraper.ts b/src/content/quoteRecords/_scraper.ts
@@ -79,11 +79,9 @@ for (const rateRow of rateRows) {
 }
 
 for (const [currency, rateByDate] of rateByDateByCurrency) {
+  const symbol = currencyPair(currency, QUOTE_CURRENCY);
   await using file = await fs.open(
-    new URL(
-      "./" + currencyPair(currency, QUOTE_CURRENCY) + ".json",
-      import.meta.url,
-    ),
+    new URL("./" + symbol + ".json", import.meta.url),
     fs.constants.O_RDWR | fs.constants.O_CREAT,
   );
 

diff --git a/src/pages/api/v1/years/index.json.ts b/src/pages/api/v1/years/index.json.ts
@@ -3,7 +3,7 @@ import { getCollection } from "astro:content";
 
 const quoteRecords = await getCollection("quoteRecords");
 
-const currencyPairsByYear = new Map<number, string[]>();
+const symbolsByYear = new Map<number, string[]>();
 for (const quoteRecord of quoteRecords) {
   const years = [
     ...new Set(
@@ -13,14 +13,14 @@ for (const quoteRecord of quoteRecords) {
     ),
   ];
   for (const year of years) {
-    let currencyPairs = currencyPairsByYear.get(year);
-    if (currencyPairs == null) {
-      currencyPairs = [];
-      currencyPairsByYear.set(year, currencyPairs);
+    let symbols = symbolsByYear.get(year);
+    if (symbols == null) {
+      symbols = [];
+      symbolsByYear.set(year, symbols);
     }
-    currencyPairs.push(quoteRecord.id);
+    symbols.push(quoteRecord.id);
   }
 }
 
 export const GET: APIRoute = () =>
-  Response.json(Object.fromEntries(currencyPairsByYear));
+  Response.json(Object.fromEntries(symbolsByYear));