Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine internal notation #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refine internal notation #66

wants to merge 1 commit into from

Conversation

kriskowal
Copy link
Owner

This change makes the internal transcription notation, which uses the names of the tengwa, less shy about using the proper names, particularly with the use of diacritics where appropriate, and using the proper names for vowel carriers.

It’s my hope that this makes the tests more palatable as a shared asset among transcribers.

This change makes the internal transcription notation, which uses the
names of the tengwa, less shy about using the proper names, particularly
with the use of diacritics where appropriate, and using the proper names
for vowel carriers.
@vercel
Copy link

vercel bot commented Dec 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kriskowal/tengwarjs/q03nwci11
✅ Preview: https://tengwarjs-git-notation.kriskowal.now.sh

@kriskowal
Copy link
Owner Author

I was sadly unable to give vowels the same treatment, since these do not consistently have names, some of the names appear only in combination with specific tengwar, and names like sa-rince do not fully describe the flourish variations that are expressible with the fonts.

Copy link
Collaborator

@arnog arnog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (but see 1 typo: that's the requested change).

As a side note, it's always a bit risky to use non-ASCII chars in strings intended to be used for programming. For example, AFAIK the Regex engines of most Javascript engines do not handle as one would expect accented characters. There are Unicode variants of those that are available, but they are inconsistent, and AFAIR Firefox doesn't support it.

As an alternative, you could use "nuumen" for "númen", etc...

breaks.
- `plain` whether to exclude all HTML from the output,
making it suitable for plain text..
- `viyla`: In the earlier forms of the mode, the tengwa
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vilya ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants