Fix for "duplicate identifier" via generateIndexFile hook for multiple schemas #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sweep: PR ReviewSweep is currently reviewing your pr... |
|
Thank you for contributing! I do not have time to look at your branch today but I will get around to it this week and merge or suggest changes! |
|
Sorry, that took a bit longer than I anticipated. So forgive me if I am misunderstanding, but it seems that this will always change the output in that there will always be at least one schema. If that's the case then I think this should be an option instead of the default. Or perhaps the old style should be an option, I am not sure.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a global
models/index.ts, when using schemas, addmodels/schema/index.tsindex files for preventing typescript "duplicate identifier" errors when schemas contain overlapping resources (e.g. postgrest, supabase, other api-based-schema paradigms).