v 1.8.3 remove zero points in SNR data arcs

.gitignore

@@ -1,4 +1,5 @@
 env
+list_bfg.py
 noaa.txt
 idalia.py
 sso_tokens.json.save

CHANGELOG.md

@@ -3,6 +3,11 @@
 All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
+## 1.8.3
+2023 September 26
+
+Remove zero points from SNR traces in window_new.py in gnssir_v2.py
+
 ## 1.8.2
 2023 September 25
 added nmea2snr changes from naoyakadota.  Invalid lines no longer crash the code.

README.md

@@ -1,6 +1,6 @@
 # gnssrefl
 
-**github version: 1.8.2** [![PyPI Version](https://img.shields.io/pypi/v/gnssrefl.svg)](https://pypi.python.org/pypi/gnssrefl) [![DOI](https://zenodo.org/badge/doi/10.5281/zenodo.5601495.svg)](http://dx.doi.org/10.5281/zenodo.5601495) [![Documentation Status](https://readthedocs.org/projects/gnssrefl/badge/?version=latest)](https://gnssrefl.readthedocs.io/en/latest/?badge=latest)
+**github version: 1.8.3** [![PyPI Version](https://img.shields.io/pypi/v/gnssrefl.svg)](https://pypi.python.org/pypi/gnssrefl) [![DOI](https://zenodo.org/badge/doi/10.5281/zenodo.5601495.svg)](http://dx.doi.org/10.5281/zenodo.5601495) [![Documentation Status](https://readthedocs.org/projects/gnssrefl/badge/?version=latest)](https://gnssrefl.readthedocs.io/en/latest/?badge=latest)
 
 Our documentation is available [here.](https://gnssrefl.readthedocs.io/en/latest/)
 

docs/pages/quick_recall.md

@@ -1,10 +1,15 @@
 # Quick Links to the Code
 
+I originally made special documentation pages for different modules. I am now trying to
+put all documentation INTO the code itselsf using readthedocs. That includes example calls. While 
+I still have some discussion pages (so a link to the code and a link to a discussion page),
+those discussion links will likely go away in the not very distant future.
+
 ## Main Functions
 
-* [rinex2snr code](https://gnssrefl.readthedocs.io/en/latest/api/gnssrefl.rinex2snr_cl.html) 
+* [rinex2snr](https://gnssrefl.readthedocs.io/en/latest/api/gnssrefl.rinex2snr_cl.html) 
 
-* [quickLook code](https://gnssrefl.readthedocs.io/en/latest/api/gnssrefl.quickLook_cl.html)
+* [quickLook](https://gnssrefl.readthedocs.io/en/latest/api/gnssrefl.quickLook_cl.html)
 
 * [gnssir code](https://gnssrefl.readthedocs.io/en/latest/api/gnssrefl.gnssir_cl.html),
  [gnssir inputs](https://gnssrefl.readthedocs.io/en/latest/api/gnssrefl.gnssir_input.html)
@@ -23,7 +28,7 @@
 [discussion](https://gnssrefl.readthedocs.io/en/latest/pages/README_invsnr.html),
 [invsnr_input](https://gnssrefl.readthedocs.io/en/latest/api/gnssrefl.invsnr_input.html)
 
-* [refl_zones code](https://gnssrefl.readthedocs.io/en/latest/api/gnssrefl.refl_zones_cl.html)
+* [refl_zones](https://gnssrefl.readthedocs.io/en/latest/api/gnssrefl.refl_zones_cl.html)
 
 
 ## Environmental Products

gnssrefl/gnssir_v2.py

@@ -747,20 +747,33 @@ def window_new(snrD, f, satNu,ncols,pele,pfitV,e1,e2,azlist,screenstats):
     icol = column - 1
     #print('using frequency ', f, ' columns ', ncols)
 
-    sat = snrD[:,0]
-    ele = snrD[:,1]
-    azm = snrD[:,2]
-    seconds = snrD[:,3]
-    edot = snrD[:,4] # but does not have to exist?
 
     if (column <= ncols) : 
         # at least there is a column where there should be
-        data = snrD[:,icol]
-        if (np.sum(data)) < 1:
-            if screenstats:
-                print('no useful data, all zeros')
+        # sep 26, 2023
+        # these definitions used to be outside the if, but putting them inside now
+        datatest = snrD[:,icol]
+        ijk = (datatest == 0)
+        nzero = len(datatest[ijk])
+        if np.sum(datatest) < 1:
+            print('No useful data on frequency ', f , ': all zeros')
             good = False
         else:
+            if nzero > 0:
+                #print('removing ', nzero, ' zero points on frequency ', f )
+                # indices you are keeping ... 
+                nn = (datatest > 0) ; 
+                snrD = snrD[nn,:]
+
+        sat = snrD[:,0]
+        ele = snrD[:,1]
+        azm = snrD[:,2]
+        seconds = snrD[:,3]
+        edot = snrD[:,4] # but does not have to exist?
+        data = snrD[:,icol]
+
+        # not really good - but at least the zeros have been removed
+        if good:
             # change to linear units
             data = np.power(10,(data/20))
             if len(ele) > 20:

setup.py

@@ -42,7 +42,7 @@
 ]
 setup(
     name="gnssrefl",
-    version="1.8.2",
+    version="1.8.3",
     author="Kristine Larson",
     author_email="[email protected]",
     description="A GNSS reflectometry software package ",