Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or document Ubuntu compiler issues #84

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

DJLevel3
Copy link

I have been having some issues with getting Oscilloscope to compile on Ubuntu, but I found workarounds and fixes for everything. This PR should fix everything or document the workarounds until a real fix comes.

@DJLevel3
Copy link
Author

After fixing a bunch of stuff, it's done! I'm marking it ready fro review!

@DJLevel3 DJLevel3 marked this pull request as ready for review August 29, 2022 21:34
@DJLevel3
Copy link
Author

Oops, it's not working. Don't merge yet.

@DJLevel3
Copy link
Author

It works now!!! YAY!!! Ready to merge.

@DJLevel3
Copy link
Author

DJLevel3 commented Sep 7, 2022

Any updates? I don't have the permissions to merge a PR myself so I need someone who does to merge it for me. I tested the process from start to finish and it works perfectly.

@walksanatora
Copy link

im on arch, but if i pull from your branch
will it work

@walksanatora
Copy link

might i suggest possibly making the other dependicies a sub module
and fixing the compile paths
so that i dont have to remember to clone other repos

@kritzikratzi
Copy link
Owner

hey!

thanks for looking into it.

for the two problems with the addons i believe updating the submodules to the latest version fixes both (missing cstdio in liblaserdock, missing include guards in ofxNative, i believe @DJLevel3 fixed those) so both the remarks in the readme and the sed command is fortunately already obsolete.

i have a few busy days ahead of me, but i'm trying to not forget!

@DJLevel3 do you have the time to start a fresh PR where you update the submodules and pick the changes from the readme that are still relevant, so that it's a single commit that i can review?

i'm leaving this PR open either way for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants