-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): add system test on withdrawal after MPT transition #400
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
c368177
to
5415712
Compare
78461a5
to
9dd076b
Compare
The e2e test is irregularly failing, so I may look into that issue tomorrow and merge after solving this. |
Added a system test for
proveWithdrawal
after MPT transition.The previous
SendDeposit
function has always been failing to get receipt from L2 even after the transition to MPT, which I think the deposit tx is yet to be included in L2. Instead of waiting for some random number of blocks, I revised the function to takeisKromaMPT
flag.