Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable renewal time #67

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

evanrichter
Copy link
Contributor

this allows certificates to be queued for renewal when within a custom amount of days, not just 30. I kept 30 as the default, so this shouldn't break any currently working configs!

"renewal_days_advance" can now be used to configure how many days
before expiry should renewal be attempted
@krtab krtab force-pushed the configurable-days branch from d2d1aee to 0202a4c Compare December 6, 2024 09:35
@krtab
Copy link
Owner

krtab commented Dec 6, 2024

Hi!

Thanks a lot for your contribution. I've nitpicked a few things (including changing the configuration key to the more explicit renewal_days_advance) and will merge once CI is passing.

@krtab krtab merged commit aaadeb4 into krtab:main Dec 6, 2024
1 check passed
@evanrichter
Copy link
Contributor Author

awesome, works for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants