Skip to content

Commit

Permalink
Modified id to experiment_id
Browse files Browse the repository at this point in the history
  • Loading branch information
chandrams authored and johnaohara committed Apr 27, 2022
1 parent 52fc81e commit e63a20f
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
20 changes: 10 additions & 10 deletions src/gRPC/hpo_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/gRPC/protos/hpo.proto
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ message ExperimentDetails {
int32 parallel_trials = 3;
string direction = 4;
string hpo_algo_impl = 5;
string id_ = 6;
string experiment_id = 6;
string objective_function= 7;
repeated Tunable tuneables = 8;
string value_type= 9;
Expand Down
6 changes: 3 additions & 3 deletions src/grpc_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ def NewExperiment(self, request, context):
tuneables = []
for tuneable in request.tuneables:
tuneables.append(json.loads(MessageToJson(tuneable, preserving_proto_field_name=True)))
hpo_service.instance.newExperiment(request.id_, request.experiment_name,
hpo_service.instance.newExperiment(request.experiment_id, request.experiment_name,
request.total_trials, request.parallel_trials,
request.direction, request.hpo_algo_impl,
request.objective_function,
tuneables, request.value_type)
hpo_service.instance.startExperiment(request.id_)
experiment: HpoExperiment = hpo_service.instance.getExperiment(request.id_)
hpo_service.instance.startExperiment(request.experiment_id)
experiment: HpoExperiment = hpo_service.instance.getExperiment(request.experiment_id)
reply: NewExperimentsReply = NewExperimentsReply()
reply.trial_number = experiment.trialDetails.trial_number
context.set_code(grpc.StatusCode.OK)
Expand Down

0 comments on commit e63a20f

Please sign in to comment.