perf: improve query performance for Metric.latest #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it pulls all records from the database but only uses the most recent amount value. This is inefficient, particularly if the database is large. Now it only retrieves the amount from the most recent record and ignores all the old ones.
paulsturgess
force-pushed
the
improve-latest-perf
branch
from
efa5350
to
56d5c4a
Compare
paulsturgess
commented
Apr 30, 2024
Comment on lines
-6
to
+8
| gem 'sqlite3' | ||
| gem 'sqlite3', '~> 1.4' |
There was a problem hiding this comment.
this is the highest version active record 7.0 supports:
jimehk
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it pulls all records from the database but only uses the most recent amount value.
This is inefficient, particularly if the database is large. Now it only retrieves the amount from the most recent record and ignores all the old ones.
I haven't added any tests because this method is already well covered and the underlying logic remains the same.