Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong relative path in symbolic link #1350

Conversation

pavel-trafimuk
Copy link
Contributor

@pavel-trafimuk pavel-trafimuk commented Jul 17, 2024

Fixing: #1349

destinationBinaryPath is based on cachePath, which could be relative (related to sourcery binary) and we are creating sym link (link at originalBinaryPath to destinationBinaryPath) which will be also relative, but relative sym link resolves itself not from sourcery binary but from itself.

E.g.
sourcery bin: ~/sourcery
destinationBinaryPath: /destinationBuilds
originalBinaryPath: ~/sourcery/customCache

symlink: originalBinaryPath-> destinationBinaryPath (~/sourcery/customCache will redirect to /destinationBuilds),
it resolves to ~/sourcery/customCache/destinationBuilds but should be ~/sourcery/destinationBuilds

@pavel-trafimuk
Copy link
Contributor Author

@art-divin @krzysztofzablocki

@art-divin art-divin merged commit 81033ec into krzysztofzablocki:master Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants