Fixed wrong relative path in symbolic link #1350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing: #1349
destinationBinaryPath
is based on cachePath, which could be relative (related to sourcery binary) and we are creating sym link (link atoriginalBinaryPath
todestinationBinaryPath
) which will be also relative, but relative sym link resolves itself not from sourcery binary but from itself.E.g.
sourcery bin:
~/sourcery
destinationBinaryPath:
/destinationBuilds
originalBinaryPath:
~/sourcery/customCache
symlink: originalBinaryPath-> destinationBinaryPath (
~/sourcery/customCache
will redirect to/destinationBuilds
),it resolves to
~/sourcery/customCache/destinationBuilds
but should be~/sourcery/destinationBuilds