Skip to content

Commit

Permalink
manifests: Update gateways and prefix (#32)
Browse files Browse the repository at this point in the history
* manifests: Use explicit gateways

Replace the variable substitution for the web app and hardcode the
Gateway that will be used in each case.

Signed-off-by: Kimonas Sotirchos <[email protected]>

* manifests: Set the prefix in the backend

The backend should also be aware of the prefix in order to configure the
frontend files accordingly.

Signed-off-by: Kimonas Sotirchos <[email protected]>
  • Loading branch information
kimwnasptd committed Mar 4, 2022
1 parent b55412d commit dd7e798
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion config/base/istio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
namespace: kserve
spec:
gateways:
- $(ingressGateway)
- knative-serving/knative-ingress-gateway
hosts:
- '*'
http:
Expand Down
1 change: 1 addition & 0 deletions config/overlays/kubeflow/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ configMapGenerator:
behavior: replace
literals:
- USERID_HEADER=kubeflow-userid
- APP_PREFIX=/kserve-endpoints

configurations:
- params.yaml
4 changes: 4 additions & 0 deletions config/overlays/kubeflow/patches/web-app-vsvc.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
- op: replace
path: /spec/gateways
value:
- kubeflow/kubeflow-gateway
- op: replace
path: /spec/http/0/route/0/destination
value:
Expand Down

0 comments on commit dd7e798

Please sign in to comment.