Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use latest image tag #42

Merged
merged 1 commit into from
May 27, 2024
Merged

chore: Use latest image tag #42

merged 1 commit into from
May 27, 2024

Conversation

spolti
Copy link
Contributor

@spolti spolti commented May 20, 2024 •
edited by ckadner
Loading

This was referenced May 20, 2024
Merged
Merged
rafvasq
rafvasq approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@oss-prow-bot oss-prow-bot bot added the lgtm label May 27, 2024
@oss-prow-bot OSS-prow-bot
Copy link

oss-prow-bot bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rafvasq, spolti

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rafvasq rafvasq changed the title Use latest tag to grab updates upon new build chore: Use latest image tag May 27, 2024
@rafvasq rafvasq merged commit 8e6487b into kserve:main May 27, 2024
5 of 6 checks passed
ckadner
ckadner reviewed May 27, 2024
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a specific version to ensure reproducible builds and/or to trace back in time when something last worked how/why what changed when ...

Dockerfile Show resolved Hide resolved
@ckadner ckadner mentioned this pull request May 28, 2024
Closed
@ckadner ckadner mentioned this pull request Jun 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckadner ckadner ckadner left review comments

@rafvasq rafvasq rafvasq approved these changes

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

@rafvasq rafvasq

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spolti @rafvasq @ckadner