Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scrollY when the GridView has vertical spacing #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix scrollY when the GridView has vertical spacing #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...y/src/main/java/com/github/ksoichiro/android/observablescrollview/ObservableGridView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,14 @@ protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
}
}

@Override public int getVerticalSpacing() {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {
return super.getVerticalSpacing();
}
// getVerticalSpacing was added in 16. We could use reflection to get the value on pre-JB, but that would be expensive.
return 0;
}

private void init() {
mChildrenHeights = new SparseIntArray();
mHeaderViewInfos = new ArrayList<>();
Expand Down Expand Up @@ -435,7 +443,7 @@ private void onScrollChanged() {
}
}
}
mPrevScrolledChildrenHeight += mPrevFirstVisibleChildHeight + skippedChildrenHeight;
mPrevScrolledChildrenHeight += mPrevFirstVisibleChildHeight + skippedChildrenHeight + getVerticalSpacing();
mPrevFirstVisibleChildHeight = firstVisibleChild.getHeight();
} else if (firstVisiblePosition < mPrevFirstVisiblePosition) {
// scroll up
Expand All @@ -447,7 +455,7 @@ private void onScrollChanged() {
}
}
}
mPrevScrolledChildrenHeight -= firstVisibleChild.getHeight() + skippedChildrenHeight;
mPrevScrolledChildrenHeight -= firstVisibleChild.getHeight() + skippedChildrenHeight + getVerticalSpacing();
mPrevFirstVisibleChildHeight = firstVisibleChild.getHeight();
} else if (firstVisiblePosition == 0) {
mPrevFirstVisibleChildHeight = firstVisibleChild.getHeight();
Expand Down