Add support for User models with renamed username field.
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django supports having different name for usernames. It's very common to use `email` as username, and the Django framework profived all nessesary features to do that in a convenient way, i.e. methods to set and access those fields without knowing their exact names. This commit fixed the current user interaction in CAS client to use the mentioned above methods, as it recommended by Django core and implemented in their statndard ModelBackend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django supports having different field name for usernames. It's very
common to use
emailas username, and the Django frameworkprofived all nessesary features to do that in a convenient way,
i.e. methods to set and access those fields without knowing
their exact names.
This commit fixed the current user interaction in CAS client
to use the mentioned above methods, as it recommended by Django
core and implemented in their standard ModelBackend.