Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider the following formatting changes to #13259 #291

Open
wants to merge 1 commit into
base: pr13259
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Framework/Core/include/Framework/ASoA.h
Original file line number Diff line number Diff line change
Expand Up @@ -782,8 +782,9 @@ struct ColumnDataHolder {
};

template <typename T, typename B>
concept CanBind = requires(T&& t) {
{ t.B::mColumnIterator };
concept CanBind = requires(T&& t)
{
{t.B::mColumnIterator};
};

template <typename IP, typename... C>
Expand Down Expand Up @@ -978,12 +979,11 @@ struct RowViewCore : public IP, C... {
// error if constructor for the table or any other thing involving a missing
// binding is preinstanciated.
template <typename B>
requires(CanBind<typename table_t::iterator, B>)
decltype(auto) getDynamicBinding()
requires(CanBind<typename table_t::iterator, B>) decltype(auto) getDynamicBinding()
{
static_assert(std::is_same_v<decltype(&(static_cast<B*>(this)->mColumnIterator)), std::decay_t<decltype(B::mColumnIterator)>*>, "foo");
return &(static_cast<B*>(this)->mColumnIterator);
//return static_cast<std::decay_t<decltype(B::mColumnIterator)>*>(nullptr);
// return static_cast<std::decay_t<decltype(B::mColumnIterator)>*>(nullptr);
}

template <typename B>
Expand Down
Loading