Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundled version of l3 riscv model and step #195

Merged
merged 16 commits into from
Dec 5, 2024
Merged

Conversation

palmskog
Copy link
Collaborator

@palmskog palmskog commented Dec 5, 2024

@didriklundberg is this what you had in mind? I took the latest files from the dev_riscv_l3_t1_2 branch.

@didriklundberg didriklundberg self-requested a review December 5, 2024 16:30
@didriklundberg
Copy link
Member

@didriklundberg is this what you had in mind? I took the latest files from the dev_riscv_l3_t1_2 branch.

No, take the files from trindemossen-1 as I wrote on Zulip. Then I will contribute my changes on top of those files. Also, I see you did not add the copyright notice of the "HOL4 CONTRIBUTORS".

@palmskog
Copy link
Collaborator Author

palmskog commented Dec 5, 2024

@didriklundberg OK now?

@didriklundberg
Copy link
Member

@didriklundberg OK now?

You forgot to remove riscv_stepSimps.sig and riscv_stepSimps.sml.

@didriklundberg
Copy link
Member

Okay, I added the changes now. Here's a PR into l3-riscv with the additions on the HolBA side, which I suggest we handle before merging this PR.

Support for CSR instructions and registers in RISC-V lifter and backlifter
@palmskog
Copy link
Collaborator Author

palmskog commented Dec 5, 2024

@didriklundberg apparently an ARM(!) self test is failing, could you take a look?

 Failed tests: (1 total)
- src/tools/lifter/selftest_arm.exe

@didriklundberg
Copy link
Member

@didriklundberg apparently an ARM(!) self test is failing, could you take a look?

 Failed tests: (1 total)
- src/tools/lifter/selftest_arm.exe

Looks like two failing instructions switching order: benign, but unexpected. Let me take a look at what could have caused this.

@didriklundberg
Copy link
Member

@didriklundberg apparently an ARM(!) self test is failing, could you take a look?

 Failed tests: (1 total)
- src/tools/lifter/selftest_arm.exe

The reason for failure is the change to src/tools/lifter/selftestLib.sml which now lists lifter failures in order of occurrence, rather than reverse order of occurrence. I suggest pushing the updated arm8 selftest log: if you think this is solution is OK, I can fix it.

@palmskog
Copy link
Collaborator Author

palmskog commented Dec 5, 2024

I suggest pushing the updated arm8 selftest log: if you think this is solution is OK, I can fix it.

Please go ahead and fix, also feel free to merge this into riscv-symbexec when it makes CI green.

@didriklundberg didriklundberg merged commit 4e934d6 into riscv-symbexec Dec 5, 2024
4 checks passed
@palmskog palmskog deleted the l3-riscv branch December 6, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants