vmm-task:individually specify task.debug to enable debug_console #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyflypeng
reviewed
Aug 28, 2023
vmm/task/src/config.rs
Outdated
| if p == TASK_DEBUG { | ||
| config.debug = true; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Shall we keep the parse the TASK_DEBUG param like the following parase_cmdline macro?
|
Maybe need to update the docs about |
Vanient
force-pushed
the
main
branch
4 times, most recently
from
4de17f1
to
17ef9bc
Compare
updated |
Vanient
force-pushed
the
main
branch
2 times, most recently
from
b097e7d
to
7edfca0
Compare
flyflypeng
approved these changes
Aug 28, 2023
|
Please check your commit. |
Before this we reuse "task.log_level" to determine whether listening debug console port, which is not so good, individually specifying task.debug to enable debug_console is needed. Signed-off-by: Vanient <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this we reuse "task.log_level" to determine whether listening debug console port, which is not so good, individually specifying task.debug to enable debug_console is needed.