Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm: collect cgroup metrics as stats in wasmedge #74

Merged
merged 1 commit into from
Sep 9, 2023
Merged

wasm: collect cgroup metrics as stats in wasmedge #74

merged 1 commit into from
Sep 9, 2023

Conversation

hydai
Copy link
Contributor

@hydai hydai commented Aug 30, 2023

Fixes #64

@Burning1020
Copy link
Member

@hydai Thanks for the PR. But we found a problem that wasm-sandboxer process hasn't been added to container Cgroup.
So let us keep this PR open until we fix that problem.

@Poorunga Poorunga mentioned this pull request Sep 8, 2023
Merged
@Burning1020
Copy link
Member

@hydai Thanks for the PR. But we found a problem that wasm-sandboxer process hasn't been added to container Cgroup. So let us keep this PR open until we fix that problem.

As #87 has fixed it up, we can now merge it.

Burning1020
Burning1020 approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Burning1020 Burning1020 merged commit 7c18d6f into kuasar-io:main Sep 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Burning1020 Burning1020 Burning1020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The implementation of stats task service and Cgroup setup for wasm sandboxer
2 participants
@hydai @Burning1020