Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] remove SIGTERM and SIGINT signal handling #79

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

Youtirsin
Copy link
Contributor

@Youtirsin Youtirsin commented Sep 2, 2023

Remove SIGTERM and SIGINT signal handling. Shutdown when received them.

@Youtirsin Youtirsin requested a review from a team as a code owner September 2, 2023 11:26
@Youtirsin Youtirsin force-pushed the sigterm branch 4 times, most recently from 7760f1c to 8f6e1b5 Compare September 2, 2023 12:33
@Youtirsin Youtirsin changed the title [wasm] changed SIGTERM signal handling [wasm] remove SIGTERM and SIGINT signal handling Sep 5, 2023
@Burning1020
Copy link
Member

One more thing, could you please squash your commit into one?

@Youtirsin
Copy link
Contributor Author

One more thing, could you please squash your commit into one?

okay, done it.

Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Burning1020 Burning1020 merged commit 117a271 into kuasar-io:main Sep 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants