Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump up fluent-plugin-gcs version to 0.4.3 #103

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

rafaelpissolatto
Copy link
Contributor

This feature changes the fluent-plugin-gcs source and bumps up the version from 0.4.0 to 0.4.3. Also, we expect to resolve some issue regarding the error "got unrecoverable error in primary and no secondary error_class=ArgumentError error="wrong number of arguments (given 2, expected 1)" when we try to use the GCS.

@pepov
Copy link
Member

pepov commented Jan 3, 2024

@rafaelpissolatto the original plugin had a patch that the logging operator expects, so we will have to rebase the fork and use the plugin from there. I can't do it now, but let's keep this PR open so that I don't forget to handle it during the week.

@OverOrion
Copy link
Contributor

Hey @rafaelpissolatto

I opened a draft PR which updates the fork: kube-logging/fluent-plugin-gcs#2

Could you give it a try?

@rafaelpissolatto rafaelpissolatto changed the title change source and bump up version fluent-plugin-gcs to 0.4.3 feat: bump up fluent-plugin-gcs version to 0.4.3 Jan 4, 2024
@rafaelpissolatto
Copy link
Contributor Author

Hello @OverOrion @pepov

I did try building an image using the ref (commit) f18a48914cc0e09df313791c947ca7eb3d0d0148 from the kube-logging/fluent-plugin-gcs (synched) and looks resolved the issue regarding the error "got unrecoverable error in primary and no secondary error_class=ArgumentError error="wrong number of arguments (given 2, expected 1)" (logs are being uploaded to GCS bucket as expected);
LMK if I need to do something diff in this PR, please; Thanks.

Signed-off-by: Peter Wilcsinszky <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]>
@pepov
Copy link
Member

pepov commented Jan 5, 2024

I've merged the branch in the fork to master and updated the ref. Will try to submit the patch upstream so that we don't have to maintain the fork anymore.

@pepov pepov self-requested a review January 5, 2024 09:19
@pepov pepov merged commit d87c3bc into kube-logging:main Jan 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants