Fluentd 1.16 base image #81
Closed
+507
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
pepov
reviewed
Oct 20, 2023
v1.16/Dockerfile
Outdated
Comment on lines
57
to
61
| RUN apk update \ | ||
| && apk add --no-cache --virtual .build-deps \ | ||
| build-base \ | ||
| ruby-dev gnupg \ | ||
| && apk add $BUILD_DEPS \ |
There was a problem hiding this comment.
isn't this already installed in the base?
There was a problem hiding this comment.
I was a bit hasty, sorry!
The are installed and then removed at every stage, so each image/stage is as small as possible, that's why it seemed like a duplicate, but it's not.
I am open to just installing it during the first stage and only removing it at the last stage, if you think it's not worth it.
There was a problem hiding this comment.
depends on how big the result will be, but would make the dockerfile much simpler
There was a problem hiding this comment.
The difference on the base target is 3 MBs:
$ docker images | grep clean
fluentd-base-without-cleaned-up latest fa9756961272 4 seconds ago 189MB
fluentd-base-cleaned-up latest ca135c728c7a About a minute ago 192MB
I think it makes sense to keep it in this case.
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
|
Superseded by #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a three stages docker build:
base=> only the label router is addedminimal=> some plugins are addedfull=> all plugins are addedI am more than happy to change which plugin goes where, just let me know.
Proof for the base image successfully running the E2E tests: OverOrion/logging-operator#3