-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add the ua-parser plugin to the filter plugins #88
Conversation
Signed-off-by: Csaba Tűz <[email protected]>
bcd45c8
to
4d0a615
Compare
Signed-off-by: Peter Wilcsinszky <[email protected]>
@csabatuz-chess thanks for your contribution! I just realized we haven't added a check to make sure the lock file is in sync with the dependencies so I've just updated it manually and will add a follow up issue to make sure the CI is checking it |
follow up: #89 |
@pepov Thanks for the mopping-up, the lockfile evaded my attention. I am following a somewhat selfish path here, we are using Thanks again, looking forward to discuss this and the other PR, let me know if I took a wrong turn in either, and I'll correct. |
All good, thanks for the context! Today we have capacity to support a single image with three layers (base,filters,full), so if there is a legitimate use of a plugin we can add it to one of these layers, just as you did. There is a chance that a new plugin introduces a security vulnerability or some regression and in that case we might have to pull it out and then you will have to add it and build it on your own on top of our base. In this case it doesn't make any changes in the existing dependencies and if the plugin is not used I don't see it doing any harm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, much appreciated! 🙌
Thank you, please also take a look at the PR that attemps to use this new plugin: |
This changeset adds the https://github.com/bungoume/fluent-plugin-ua-parser Fluent plugin to the filters.
Required for: kube-logging/logging-operator#1594