add valid_until to Client
#3645
goenningAnnotations
2 errors and 2 warnings
|
useless conversion to the same type: `std::string::String`:
kube-runtime/src/events.rs#L272
error: useless conversion to the same type: `std::string::String`
--> kube-runtime/src/events.rs:272:34
|
272 | note: ev.note.clone().map(Into::into),
| ^^^^^^^^^^^^^^^^ help: consider removing
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
note: the lint level is defined here
--> kube-runtime/src/lib.rs:11:9
|
11 | #![deny(clippy::all)]
| ^^^^^^^^^^^
= note: `#[deny(clippy::useless_conversion)]` implied by `#[deny(clippy::all)]`
|
|
clippy_nightly
Clippy has exited with exit code 101
|
|
clippy_nightly
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
empty line after doc comment:
kube-client/src/client/config_ext.rs#L293
warning: empty line after doc comment
--> kube-client/src/client/config_ext.rs:293:5
|
293 | / /// A tuple containing an optional vector of bytes representing the identity and an optional expiration date.
294 | |
| |_^
...
299 | pub fn exec_identity_pem(&self) -> (Option<Vec<u8>>, Option<DateTime<Utc>>) {
| --------------------------------------------------------------------------- the comment documents this method
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
help: if the doc comment should not document `exec_identity_pem` comment it out
|
287 ~ // /// Retrieves an identity when an exec plugin returns a client certificate and key instead of a token.
288 ~ // ///
289 ~ // /// This is necessary to check on TLS configuration vs tokens which can be added in as an AuthLayer.
290 ~ // ///
291 ~ // /// # Returns
292 ~ // ///
293 ~ // /// A tuple containing an optional vector of bytes representing the identity and an optional expiration date.
|
|