Minor fixes to ObjectList
#1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion The `serde` crate has a bug that prevents the proper deserialization of attributes that are using the `flatten` and `default` directives. See [1] and [2]. This bug affects the freshly introduced `ObjectList.types` attribute. It's not possible to deserialize an `ObjectList` that is missing the `apiVersion` and/or the `kind` values. This commit introduces a custom deserializer for the `types` attribute of `ObjectList`. On top of handling the deserialization case, the custom deserializer provides better default values compared to the ones of the stock `TypeMeta`. The `TypeMeta` struct has empty strings as default values. However, in the context of `ObjectList`, proper default values should be `v1` and `List` instead. [1] serde-rs/serde#1626 [2] serde-rs/serde#1879 Signed-off-by: Flavio Castelli <[email protected]>
Ensure `ObjectList` derive the `Clone` trait. Signed-off-by: Flavio Castelli <[email protected]>
clux
approved these changes
Jan 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
=======================================
+ Coverage 72.1% 72.1% +0.1%
=======================================
Files 75 75
Lines 6458 6470 +12
=======================================
+ Hits 4651 4663 +12
Misses 1807 1807
|
Signed-off-by: Flavio Castelli <[email protected]>
|
@clux thanks for the review. I've pushed a commit that fixes the rustfmt issue |
|
Thanks! Released in 0.88.1 |
flavio
added a commit
to flavio/kwctl
that referenced
this pull request
Jan 29, 2024
kube 0.88.0 introduced a minor regression: kube-rs/kube#1398 That caused kwctl 1.10.0 to fail while running e2e tests under specific circumstances. Replaying a host capabilities sessions recorded with an older version of kwctl would cause Rego policies to fail. waPC policies would not fail. This patch release of kwctl addresses this specific regression. Signed-off-by: Flavio Castelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Starting from the
0.88.0release,ObjectListhas a new attribute namedtypes. This attribute is serialized and deserialized using theflattendirective of serde.However, it turns out that
serdehas a bug that prevents the proper deserialization of attributes that are using theflattenanddefaultdirectives. See here and here.This serde bug affects the freshly introduced
ObjectList.typesattribute. It's not possible to deserialize anObjectListthat is missing theapiVersionand/or thekindvalues.Solution
This commit introduces a custom deserializer for the
typesattribute ofObjectListthat solves this problem.On top of handling the deserialization case, the custom deserializer provides better default values compared to the ones of the stock
TypeMeta.The
TypeMetastruct has empty strings as default values. However, in the context ofObjectList, proper default values should bev1andListinstead.There's also a second commit to this PR that makes
ObjectListderive theClonetrait. This is not related with this specific issue, but is something that some code I've written would take advantage of. If you're not fine with this specific commit I can drop it from this PR.