Serialize TerminalSize fields as PascalCase #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't seem to affect anything for the real API-server, but it's what kubectl/client-go sends. Signed-off-by: Natalie Klestrup Röijezon <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
=====================================
Coverage 72.1% 72.1%
=====================================
Files 75 75
Lines 6470 6470
=====================================
Hits 4663 4663
Misses 1807 1807
|
|
The MSRV failure seems to be unrelated to the PR. |
|
ahash forces 1.72, which is fine and within policy. can do that in a separate PR. can merge this regardless. |
clux
added a commit
that referenced
this pull request
Feb 12, 2024
for #1407 Signed-off-by: clux <[email protected]>
Merged
clux
added a commit
that referenced
this pull request
Feb 12, 2024
just bump-msrv 1.72.0 for #1407 Signed-off-by: clux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't seem to affect anything for the real API-server, but it's what kubectl/client-go sends, so we might as well align with them.