Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace futures crate api with standard library #1461

Merged

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Apr 4, 2024

Replaces futures crate's APIs with the corresponding ones in the standard library.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.0%. Comparing base (5dce83b) to head (902cab5).
Report is 1 commits behind head on main.

❗ Current head 902cab5 differs from pull request most recent head 75d3cdd. Consider uploading reports for the commit 75d3cdd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1461     +/-   ##
=======================================
- Coverage   72.1%   72.0%   -0.1%     
=======================================
  Files         78      78             
  Lines       6592    6570     -22     
=======================================
- Hits        4747    4724     -23     
- Misses      1845    1846      +1     
Files Coverage Δ
kube-client/src/client/middleware/mod.rs 94.0% <100.0%> (ø)
kube-client/src/client/mod.rs 74.4% <100.0%> (ø)
kube-runtime/src/controller/future_hash_map.rs 95.5% <ø> (ø)
kube-runtime/src/controller/runner.rs 95.2% <ø> (ø)
kube-runtime/src/reflector/mod.rs 100.0% <ø> (ø)
kube-runtime/src/scheduler.rs 97.2% <100.0%> (ø)
kube-runtime/src/utils/delayed_init.rs 97.3% <100.0%> (-0.1%) ⬇️
kube-runtime/src/utils/event_flatten.rs 92.2% <100.0%> (-0.2%) ⬇️
kube-runtime/src/utils/event_modify.rs 95.7% <100.0%> (-0.1%) ⬇️
kube-runtime/src/utils/mod.rs 62.3% <100.0%> (-0.6%) ⬇️
... and 7 more

@tottoto tottoto force-pushed the replace-futures-api-with-standard-library branch from 076d35e to 902cab5 Compare April 4, 2024 09:06
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a benefit to moving to the std::pin::pin? from looking at the example code it only seems to make the code slightly more awkward

examples/event_watcher.rs Show resolved Hide resolved
@clux clux added this to the 0.91.0 milestone Apr 5, 2024
@tottoto tottoto force-pushed the replace-futures-api-with-standard-library branch from de857b4 to 75d3cdd Compare April 5, 2024 16:18
@clux clux merged commit dac48d9 into kube-rs:main Apr 5, 2024
16 checks passed
@clux clux added the changelog-exclude changelog excluded prs label Apr 5, 2024
@tottoto tottoto deleted the replace-futures-api-with-standard-library branch April 5, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants