Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): extended VM support #1448

Merged
merged 8 commits into from
Jan 22, 2024
Merged

feat(*): extended VM support #1448

merged 8 commits into from
Jan 22, 2024

Conversation

DelusionalOptimist
Copy link
Member

@DelusionalOptimist DelusionalOptimist commented Oct 10, 2023 •
edited
Loading

Signed-off-by: Rudraksh Pareek [email protected]

Purpose of PR?:

  • Adds a new agent for reporting entire state of protected nodes
  • Refactors feeder
  • Adds policy and log services

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@DelusionalOptimist DelusionalOptimist force-pushed the delusionaloptimist/feat/extended-vm-support branch 3 times, most recently from 2c55f3e to 2b12e8a Compare October 12, 2023 11:58
nyrahul
nyrahul previously requested changes Oct 12, 2023
View reviewed changes
KubeArmor/Makefile Outdated Show resolved Hide resolved
KubeArmor/common/common.go Outdated Show resolved Hide resolved
@DelusionalOptimist DelusionalOptimist force-pushed the delusionaloptimist/feat/extended-vm-support branch 2 times, most recently from 7f15201 to 0232fde Compare October 25, 2023 12:34
@DelusionalOptimist DelusionalOptimist marked this pull request as draft November 20, 2023 10:41
Ankurk99
Ankurk99 previously requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@Ankurk99 Ankurk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions inline. Also pls remove the commented code where not required.

KubeArmor/core/dockerHandler.go Show resolved Hide resolved
KubeArmor/core/dockerHandler.go Outdated Show resolved Hide resolved
KubeArmor/policy/reversePolicyServer.go Outdated Show resolved Hide resolved
KubeArmor/common/common.go Outdated Show resolved Hide resolved
@DelusionalOptimist DelusionalOptimist force-pushed the delusionaloptimist/feat/extended-vm-support branch 5 times, most recently from 3eb37f1 to f2695ea Compare January 18, 2024 11:13
@daemon1024 daemon1024 marked this pull request as ready for review January 18, 2024 12:21
@DelusionalOptimist DelusionalOptimist force-pushed the delusionaloptimist/feat/extended-vm-support branch from f2695ea to 7a1ea58 Compare January 18, 2024 12:35
@DelusionalOptimist
syncup go mods; lint & protos
f642a76 
Signed-off-by: Rudraksh Pareek <[email protected]>
@DelusionalOptimist DelusionalOptimist force-pushed the delusionaloptimist/feat/extended-vm-support branch from 7a1ea58 to f642a76 Compare January 22, 2024 06:09
@daemon1024 daemon1024 dismissed stale reviews from nyrahul and Ankurk99 January 22, 2024 06:37

All changes handled

@daemon1024 daemon1024 merged commit 2bac1d1 into kubearmor:main Jan 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aryan-sharma11 Aryan-sharma11 Aryan-sharma11 approved these changes

@daemon1024 daemon1024 daemon1024 approved these changes

@Shreyas220 Shreyas220 Awaiting requested review from Shreyas220

@nyrahul nyrahul Awaiting requested review from nyrahul

@PrimalPimmy PrimalPimmy Awaiting requested review from PrimalPimmy

@achrefbensaad achrefbensaad Awaiting requested review from achrefbensaad

@Ankurk99 Ankurk99 Awaiting requested review from Ankurk99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DelusionalOptimist @nyrahul @Ankurk99 @daemon1024 @Aryan-sharma11