JSON output from karmor logs --json is not beautified
#439
Comments
|
This sounds good to me. Though users can use external tools like jq for beautifying but having the ability to do so in karmor itself might come in handy if user doesn't have the tools present. |
|
Agree with Rudraksh here, We also ingest these logs to some logging solutions which will prefer the default that we have now. For flag I think we can go for something like |
|
So, the final command will look something like This will require a docs update as |
|
Don't remove Edit: We can discuss more on if jsonindent is the name we prefer because it doesn't sound intuitive in my head. |
|
Yes... let's keep the current output and also the |
|
This looks good, so the final commands will look something like: The And the normal log output: Right? |
|
Hi, @navin772 ! Can I work on this enhancement? |
Currently
karmor logs --jsongives a cluttered output in a single line:{"Timestamp":1717591294,"UpdatedTime":"2024-06-05T12:41:34.673689Z","ClusterName":"default","HostName":"navin","NamespaceName":"wordpress-mysql","Owner":{"Ref":"Deployment","Name":"wordpress","Namespace":"wordpress-mysql"},"PodName":"wordpress-78bc585459-626nf","Labels":"app=wordpress","ContainerID":"26f3f479957b89e219806d62df04234a8f1660029346d11239fa9fd86f7a3cc9","ContainerName":"wordpress","ContainerImage":"wordpress:4.8-apache@sha256:6216f64ab88fc51d311e38c7f69ca3f9aaba621492b4f1fa93ddf63093768845","HostPPID":39028,"HostPID":39354,"PPID":193,"PID":199,"UID":0,"ProcessName":"/usr/bin/curl","PolicyName":"DefaultPosture","Type":"MatchedPolicy","Source":"/usr/bin/curl goo.gl","Operation":"Network","Resource":"protocol=UDP,type=SOCK_DGRAM","Data":"lsm=SOCKET_CREATE protocol=UDP,type=SOCK_DGRAM","Enforcer":"BPFLSM","Action":"Block","Result":"Permission denied","Cwd":"/"}By using
MarshalIndentinstead ofMarshalwe can get beautified output like this:{ "Timestamp": 1717591662, "UpdatedTime": "2024-06-05T12:47:42.500041Z", "ClusterName": "default", "HostName": "navin", "NamespaceName": "wordpress-mysql", "Owner": { "Ref": "Deployment", "Name": "wordpress", "Namespace": "wordpress-mysql" }, "PodName": "wordpress-78bc585459-626nf", "Labels": "app=wordpress", "ContainerID": "26f3f479957b89e219806d62df04234a8f1660029346d11239fa9fd86f7a3cc9", "ContainerName": "wordpress", "ContainerImage": "wordpress:4.8-apache@sha256:6216f64ab88fc51d311e38c7f69ca3f9aaba621492b4f1fa93ddf63093768845", "HostPPID": 39028, "HostPID": 43125, "PPID": 193, "PID": 201, "UID": 0, "ProcessName": "/usr/bin/curl", "PolicyName": "DefaultPosture", "Type": "MatchedPolicy", "Source": "/usr/bin/curl goo.gl", "Operation": "Network", "Resource": "protocol=UDP,type=SOCK_DGRAM", "Data": "lsm=SOCKET_CREATE protocol=UDP,type=SOCK_DGRAM", "Enforcer": "BPFLSM", "Action": "Block", "Result": "Permission denied", "Cwd": "/" }Let me know if this is required, I will create a PR for the same.
The text was updated successfully, but these errors were encountered: