Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduced an output flag #446

Closed
wants to merge 5 commits into from
Closed

Conversation

EraKin575
Copy link
Contributor

introduced option flags to beautify logs

fixes: #439

@navin772
Copy link
Member

Hi @EraKin575 thanks for the PR but I cannot seem to get the desired output with karmor logs --output pretty-json, it just prints the normal output as in karmor logs.

You need to change the WatchTelemetryHelper function.
Also, for the -o shorthand use StringVarP() instead of StringVar().

In this process, I ended up solving the issue. I can guide you with the solution or if you don't mind I can open a PR and you can give your feedback there.

Signed-off-by: EraKin575 <[email protected]>
Signed-off-by: EraKin575 <[email protected]>
@EraKin575
Copy link
Contributor Author

@navin772 Sorry, I got stuck in some stuff. I have fixed the output flag. thanks for the assist

Signed-off-by: EraKin575 <[email protected]>
Signed-off-by: EraKin575 <[email protected]>
@EraKin575 EraKin575 closed this Jun 27, 2024
@EraKin575
Copy link
Contributor Author

closing due to duplicate PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON output from karmor logs --json is not beautified
2 participants