Remove arbiter api when no arbiter node present

Signed-off-by: souravbiswassanto <[email protected]>
kubedb · Nov 12, 2024 · 3cd0fd6 · 3cd0fd6
1 parent a8c8c1e
commit 3cd0fd6
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/apis/kubedb/v1/postgres_helpers.go b/apis/kubedb/v1/postgres_helpers.go
@@ -18,6 +18,7 @@ package v1
 
 import (
 	"fmt"
+	"k8s.io/apimachinery/pkg/api/equality"
 	"strconv"
 	"time"
 
@@ -306,12 +307,16 @@ func (p *Postgres) SetDefaultReplicationMode(postgresVersion *catalog.PostgresVe
 }
 
 func (p *Postgres) SetArbiterDefault() {
-	if p.Spec.Arbiter == nil {
+	if ptr.Deref(p.Spec.Replicas, 0)%2 != 0 && p.Spec.Arbiter != nil {
+		if p.Spec.Arbiter.NodeSelector == nil && p.Spec.Arbiter.Tolerations == nil && equality.Semantic.DeepEqual(p.Spec.Arbiter.Resources, kubedb.DefaultArbiter(false)) {
+			p.Spec.Arbiter = nil
+		}
+	} else if ptr.Deref(p.Spec.Replicas, 0) != 0 && ptr.Deref(p.Spec.Replicas, 0)%2 == 0 && p.Spec.Arbiter == nil {
 		p.Spec.Arbiter = &ArbiterSpec{
 			Resources: core.ResourceRequirements{},
 		}
+		apis.SetDefaultResourceLimits(&p.Spec.Arbiter.Resources, kubedb.DefaultArbiter(false))
 	}
-	apis.SetDefaultResourceLimits(&p.Spec.Arbiter.Resources, kubedb.DefaultArbiter(false))
 }
 
 func (p *Postgres) setDefaultPodSecurityContext(podTemplate *ofstv2.PodTemplateSpec, pgVersion *catalog.PostgresVersion) {